Skip to content

Fix parsing of CWalletTx::mapSaplingNoteData #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix parsing of CWalletTx::mapSaplingNoteData #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9390c65
Revert "Align to dependencies"
nuttycom Sep 5, 2025
4673aa5
Fix incorrect parsing of `CWalletTx::mapSaplingNoteData`
nuttycom Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ zcash_protocol = "0.4"
zip32 = "0.1"
orchard = "0.10"
sapling = { package = "sapling-crypto", version = "0.3", features = ["temporary-zcashd"] }
incrementalmerkletree = "0.8"
bridgetree = "0.7"
incrementalmerkletree = "0.7"
bridgetree = "0.6"

[dev-dependencies]
bc-rand = "^0.4.0"
Expand Down
7 changes: 4 additions & 3 deletions src/zcashd_wallet/wallet_tx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,14 @@ impl Parse for WalletTx {

let mut sapling_note_data = None;
if transaction.version().has_sapling() {
sapling_note_data = parse!(p, "sapling_note_data")?;
let value = parse!(p, "sapling_note_data")?;
sapling_note_data = Some(value);
}

let mut orchard_tx_meta: Option<OrchardTxMeta> = None;
if transaction.version().has_orchard() {
let meta = parse!(p, "orchard_tx_meta")?;
orchard_tx_meta = Some(meta);
let value = parse!(p, "orchard_tx_meta")?;
orchard_tx_meta = Some(value);
}

let unparsed_data = p.rest();
Expand Down
Loading