DNM: Use @nuttycom's forks of the zewif crates #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `zingo` and `zcashd` feature flags so that it's not necessary to pull in the entire dependency tree for both the zcashd and zingo converters if you don't need both.
nuttycom
force-pushed
the
dnm/nuttycom_zewif
branch
from
ec40671 to
7718773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
zingoandzcashdfeature flags so that it's not necessary to pull in the entire dependency tree for both the zcashd and zingo converters if you don't need both.This is currently in do-not-merge status, as it depends on my private forks, but I think that the feature flagging and using explicit github rev dependencies would be helpful for the version that's merged to
main.