Skip to content

Merge master key fingerprint syscall#11

Merged
miketlk merged 9 commits intoliquid_developfrom
merge-master-key-fingerprint-syscall
Dec 18, 2025
Merged

Merge master key fingerprint syscall#11
miketlk merged 9 commits intoliquid_developfrom
merge-master-key-fingerprint-syscall

Conversation

@miketlk
Copy link
Collaborator

@miketlk miketlk commented Dec 17, 2025

Summary

This PR adds support for the new OS syscall os_perso_get_master_key_identifier() for master key fingerprinting. It also restricts the key derivation path allowed to the Liquid Network app, since it's becomes unnecessary to derive the master pubkey to get the fingerprint.

Related Issues

Changes

  • Adds support for the os_perso_get_master_key_identifier() syscall
  • Testnet/regtest: restricts key derivation paths to "*/1'"
  • Liquid main network: restricts key derivation paths to "*/1776'"

Testing

Tests were updated to respect derivation path hardening. New snapshots were generated. Full test completion was achieved.

Limitations

Due to the outdated OS and SDK of the Nano S device, it's not supporting this feature. Possible workarounds are TBD.

Checklist

  • Code builds without errors
  • Tests added or updated
  • Code reviewed for security and edge cases

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 82.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/crypto.c 97.91% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miketlk miketlk self-assigned this Dec 18, 2025
@miketlk miketlk added the enhancement New feature or request label Dec 18, 2025
@miketlk miketlk linked an issue Dec 18, 2025 that may be closed by this pull request
@miketlk miketlk merged commit d32593f into liquid_develop Dec 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧩 [INTEGRATION] Support master key fingerprint syscall

2 participants