-
Notifications
You must be signed in to change notification settings - Fork 482
check for and display simplicity transaction inputs #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
philippem
commented
Oct 31, 2025
- on liquid chains, provide additional information when a transaction input is a simplicity program
- display program in base64 (not hex)
|
+1 on this change. @philippem demoed it earlier to me and it looks great. |
delta1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM untested
56ad7f3 to
3b31283
Compare
|
utACK 3b31283 Though eventually we should pull this stuff back into the API rather than doing Javascript parsing. |
|
utACK |
shesek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only some minor comments
This would be useful to have in the API, but perhaps behind a |
agree |
|
In the backend we can and maybe should do much more Simplicity parsing. |
3b31283 to
baa15b7
Compare
client/src/lib/elements.js
Outdated
| if (witnessLen !== 4 && !(witnessLen === 5 && hasAnnexBlock)) return false | ||
|
|
||
| const controlBlock = getControlBlock(vin.witness) | ||
| return controlBlock && (controlBlock.startsWith('be') || controlBlock.startsWith('bf')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do something to give this operation more semantic meaning? Ex:
function hasSimplicityTapleafVersion(controlBlock) {
return controlBlock.startsWith('be') || controlBlock.startsWith('bf');
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion, added in subsequent commit
- simplicity program displayed in base64 (not hex)
836cf6c to
066ce8d
Compare