Skip to content

Bump bitcoin deps and version #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2024
Merged

Bump bitcoin deps and version #247

merged 2 commits into from
Oct 1, 2024

Conversation

RCasatta
Copy link
Contributor

@RCasatta RCasatta force-pushed the bump_deps branch 13 times, most recently from 3cfdd28 to 2efba4c Compare September 26, 2024 10:43
@RCasatta
Copy link
Contributor Author

RCasatta commented Sep 26, 2024 •
edited
Loading

I am failing to making 1.58.0 happy and tired trying

I tried various cargo update with the version of Cargo-recent.lock but I failed to find the solution, then rolled back to initial state

Is there some way to simplify this?

@apoelstra
Copy link
Collaborator

apoelstra commented Sep 26, 2024 •
edited
Loading

The MSRV of rust-bitcoin is 1.63. You need to bump the MSRV here before you can upgrade rust-bitcoin.

Is there some way to simplify this?

No. You need to determine which dependencies have broken MSRV and manually try pinning various combinations of them. You can probably copy versions out of the Cargo-recent.lock file in rust-bitcoin.

@uncomputable
Copy link
Collaborator

I bumped the MSRV in #249. It might be worth to merge #249 first and to rebase #247 into #249.

uncomputable
uncomputable reviewed Sep 27, 2024
View reviewed changes
@RCasatta
Copy link
Contributor Author

rebased, all green.

I also added a commit adding a shell.nix that I used to test rust 1.63, let me know if have to remove it

@uncomputable
Copy link
Collaborator

We would need to extend the shell.nix to make it usable for us. For instance, we require different Rust versions. Let's remove it for now.

@RCasatta
Copy link
Contributor Author

Removed

apoelstra
apoelstra approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92e0972 successfully ran local tests

@RCasatta
Copy link
Contributor Author

RCasatta commented Oct 1, 2024 •
edited
Loading

Can we have a release (when merged)?

uncomputable
uncomputable approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@uncomputable uncomputable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92e0972

@uncomputable uncomputable merged commit 9eed013 into BlockstreamResearch:master Oct 1, 2024
16 checks passed
@uncomputable
Copy link
Collaborator

@apoelstra Let's push the new release to crates.io.

@apoelstra
Copy link
Collaborator

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@uncomputable uncomputable uncomputable approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RCasatta @apoelstra @uncomputable