Open
Conversation
Co-authored-by: William Dye <william.z.dye@gmail.com>
Co-authored-by: William Dye <william.z.dye@gmail.com>
sirakisaias
approved these changes
Oct 23, 2021
sirakisaias
left a comment
There was a problem hiding this comment.
Making sure Okta works is important since authorizing user functionality is crucial before the hand off. The changes made looks good and clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a fix per Paul's request so our checks pass in GitHub.
Fixes # (issue)
A variable named AuthRequired() was functional but we are experiencing issues with Okta as of late. That lead to breaking code that was out of our control. So our temporary answer was to comment out the code that invoked Okta like authRequired() and this was left
Type of change
Please delete options that are not relevant.
Checklist:
Not doing a loom because it's literally just a commented-out variable that isn't in use so the linter isn't mad.