Enable byteshuffle for arbitrary number of bytes #715
+119
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BLOSC_NOFILTER = 0, | ||
| //!< Byte-wise shuffle. `filters_meta` does not have any effect here. | ||
| BLOSC_BITSHUFFLE = 2, | ||
| BLOSC_SHUFFLE = 1, |
Member
There was a problem hiding this comment.
I think comments should be below for a correct rendering: https://blosc.org/c-blosc2/reference/utility_variables.html#c.BLOSC_SHUFFLE
Also, for byte-wise, filters_meta does have any effect here.
Member
FrancescAlted
left a comment
FrancescAlted
left a comment
There was a problem hiding this comment.
It would be nice if you paste actual compression ratio figures here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHUFFLE now makes use of provided filters_meta, interpreting it as number of bytestreams into which to divde input. This is useful for strings of unicode characters, since one may specify the character size (4 bytes) which will be used rather than the typesize of each array entry (4 * length of string). This typically leads to better compression (see results from
tests/b2nd/b2nd_stringshuffle.c)