fix: add missing pa_ variable in sw32_ bswap fallback#725
Merged
FrancescAlted merged 1 commit intoBlosc:mainfrom Mar 27, 2026
Merged
fix: add missing pa_ variable in sw32_ bswap fallback#725FrancescAlted merged 1 commit intoBlosc:mainfrom
FrancescAlted merged 1 commit intoBlosc:mainfrom
Conversation
The non-builtin byte-swap fallback in sw32_() uses pa_[0..3] but never declares pa_. This breaks compilation on platforms without __builtin_bswap32 or _byteswap_ulong (e.g. exotic C compilers). Add `const uint8_t *pa_ = (const uint8_t *)pa;` to match the pattern used in endian_handler() at line 57. Fixes Blosc#724.
Member
|
Thanks @Scottcjn ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #724 — the non-builtin byte-swap fallback in
sw32_()usespa_[0..3]but never declarespa_. This breaks compilation on platforms without__builtin_bswap32or_byteswap_ulong.Fix
One line added:
This matches the pattern used in
endian_handler()at line 57 of the same file, wherepa_is properly declared before use.Testing
endian_handler()#elsebranch is only reached on compilers without GCC builtins or MSVC intrinsics