-
-
Notifications
You must be signed in to change notification settings - Fork 28
Add general lazy evaluation for all blosc2 functions #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+981
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescAlted
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a couple of comments, but mainly cosmetic.
Also, make sure that the new way to compute, e.g. reductions, does perform similarly to the previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there was no double evaluation in old versions of blosc2 for reductions as there was an
is_inside_new_expr()
stack check which aborted the evaluation and returnedblosc2.zeros
during theeval
call, we have added a shape parser to avoid having to arrive atreduce_slices
for reductions. In addition, this allows us to handle other non-numexpr functions without adding the sameis_inside_newexpr()
call.This PR is thus useful since 1) it adds the possibility to compute with arbitrary blosc2 functions (such as
matmul
or evenlogaddexp
) in a lazy imperative way via the changes tone_evaluate
and 2) adds a reasonably extensive shape parser function, which is a bit more explicit than the returningblosc2.zeros
hack.For the following benchmark:
one can confirm that the new method also evaluates the reduction only once on the full operands, and takes the same time as in blosc2<=3.9.1.