Skip to content

Add a log message when a resource is missing for block states #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NikitaCartes wants to merge 1 commit into from
Closed

Add a log message when a resource is missing for block states #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/java/de/bluecolored/bluemap/core/map/hires/blockmodel/BlockRendererType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
*/
package de.bluecolored.bluemap.core.map.hires.blockmodel;

import de.bluecolored.bluemap.core.logger.Logger;
import de.bluecolored.bluemap.core.map.TextureGallery;
import de.bluecolored.bluemap.core.map.hires.RenderSettings;
import de.bluecolored.bluemap.core.resources.pack.resourcepack.ResourcePack;
Expand All @@ -34,11 +35,14 @@
import lombok.Getter;
import lombok.RequiredArgsConstructor;

import java.util.HashSet;

public interface BlockRendererType extends Keyed, BlockRendererFactory {

BlockRendererType DEFAULT = new Impl(Key.bluemap("default"), ResourceModelRenderer::new);
BlockRendererType LIQUID = new Impl(Key.bluemap("liquid"), LiquidModelRenderer::new);
BlockRendererType MISSING = new Impl(Key.bluemap("missing"), MissingModelRenderer::new);
HashSet<BlockState> missingBlockStates = new HashSet<>();

Registry<BlockRendererType> REGISTRY = new Registry<>(
DEFAULT,
Expand All @@ -61,6 +65,9 @@ public interface BlockRendererType extends Keyed, BlockRendererFactory {
* @return true if this renderer-type can render the provided {@link BlockState} despite missing resources.
*/
default boolean isFallbackFor(BlockState blockState) {
if (missingBlockStates.contains(blockState)) return false;
missingBlockStates.add(blockState);
Logger.global.logDebug("Missing resources for blockState: " + blockState);
return false;
}

Expand Down
Loading