Skip to content

Conversation

@LincolnPuzey
Copy link
Collaborator

@LincolnPuzey LincolnPuzey commented Nov 29, 2025

The latest watchdog+gevent seems to work together with no extra changes (gorakhargosh/watchdog#306). Bump dramatiq's required versions of them to latest.

@LincolnPuzey
Copy link
Collaborator Author

I also ran the skipped-on-ci tests in test-watch.py:

python3 pytest-gevent.py "tests/test_watch.py"

which passed

@LincolnPuzey
Copy link
Collaborator Author

Example restarting an app when running with gevent

~/PycharmProjects/dramatiq$ PYTHONWARNINGS=all  dramatiq-gevent my_app --watch .
[2025-11-29 11:32:58,158] [PID 15914] [MainThread] [dramatiq.WorkerProcess(3)] [INFO] Worker process is ready for action.
[2025-11-29 11:32:58,160] [PID 15910] [MainThread] [dramatiq.MainProcess] [INFO] Dramatiq '2.0.0' is booting up.
[2025-11-29 11:32:58,154] [PID 15912] [MainThread] [dramatiq.WorkerProcess(1)] [INFO] Worker process is ready for action.
[2025-11-29 11:32:58,151] [PID 15911] [MainThread] [dramatiq.WorkerProcess(0)] [INFO] Worker process is ready for action.
[2025-11-29 11:32:58,156] [PID 15913] [MainThread] [dramatiq.WorkerProcess(2)] [INFO] Worker process is ready for action.
[2025-11-29 11:33:06,575] [PID 15910] [Thread-1] [SourceChangesHandler] [INFO] Detected changes to '/home/lincoln/PycharmProjects/dramatiq/my_app/__init__.py'.
[2025-11-29 11:33:06,575] [PID 15910] [Thread-1] [dramatiq.MainProcess] [INFO] Sending signal 'SIGHUP' to subprocesses...
[2025-11-29 11:33:06,575] [PID 15912] [Dummy-14] [dramatiq.WorkerProcess(1)] [INFO] Stopping worker process...
[2025-11-29 11:33:06,575] [PID 15911] [Dummy-14] [dramatiq.WorkerProcess(0)] [INFO] Stopping worker process...
[2025-11-29 11:33:06,575] [PID 15913] [Dummy-14] [dramatiq.WorkerProcess(2)] [INFO] Stopping worker process...
[2025-11-29 11:33:06,575] [PID 15914] [Dummy-14] [dramatiq.WorkerProcess(3)] [INFO] Stopping worker process...
[2025-11-29 11:33:06,577] [PID 15914] [Dummy-14] [dramatiq.WorkerProcess(3)] [WARNING] Killing worker process...
[2025-11-29 11:33:06,578] [PID 15914] [MainThread] [dramatiq.WorkerProcess(3)] [WARNING] Killing worker process...
[2025-11-29 11:33:06,577] [PID 15910] [Thread-1] [SourceChangesHandler] [INFO] Detected changes to '/home/lincoln/PycharmProjects/dramatiq/my_app/__init__.py'.
[2025-11-29 11:33:06,577] [PID 15910] [Thread-1] [dramatiq.MainProcess] [INFO] Sending signal 'SIGHUP' to subprocesses...
[2025-11-29 11:33:06,577] [PID 15910] [Thread-1] [SourceChangesHandler] [INFO] Detected changes to '/home/lincoln/PycharmProjects/dramatiq/my_app/__init__.py'.
[2025-11-29 11:33:06,577] [PID 15910] [Thread-1] [dramatiq.MainProcess] [INFO] Sending signal 'SIGHUP' to subprocesses...
[2025-11-29 11:33:06,577] [PID 15912] [Dummy-14] [dramatiq.WorkerProcess(1)] [WARNING] Killing worker process...
[2025-11-29 11:33:06,577] [PID 15911] [Dummy-14] [dramatiq.WorkerProcess(0)] [WARNING] Killing worker process...
[2025-11-29 11:33:06,578] [PID 15913] [Dummy-14] [dramatiq.WorkerProcess(2)] [WARNING] Killing worker process...
[2025-11-29 11:33:07,938] [PID 15940] [MainThread] [dramatiq.WorkerProcess(3)] [INFO] Worker process is ready for action.
[2025-11-29 11:33:07,944] [PID 15910] [MainThread] [dramatiq.MainProcess] [INFO] Dramatiq '2.0.0' is booting up.
[2025-11-29 11:33:07,941] [PID 15938] [MainThread] [dramatiq.WorkerProcess(1)] [INFO] Worker process is ready for action.
[2025-11-29 11:33:07,941] [PID 15937] [MainThread] [dramatiq.WorkerProcess(0)] [INFO] Worker process is ready for action.
[2025-11-29 11:33:07,941] [PID 15939] [MainThread] [dramatiq.WorkerProcess(2)] [INFO] Worker process is ready for action.

@LincolnPuzey LincolnPuzey added this to the v2.1.0 milestone Jan 1, 2026
@LincolnPuzey LincolnPuzey changed the title Remove watchdog_gevent compatibility library Remove usage of watchdog_gevent compatibility library Jan 18, 2026
@LincolnPuzey LincolnPuzey marked this pull request as ready for review January 18, 2026 11:38
The latest watchdog+gevent seems to work together with no extra changes.
Bump dramatiq's required versions of them to latest.
@LincolnPuzey LincolnPuzey force-pushed the remove_watchdog_gevent branch from b8cad90 to c8cfc59 Compare January 18, 2026 11:40
@LincolnPuzey LincolnPuzey merged commit 143aaa2 into Bogdanp:master Jan 18, 2026
15 checks passed
@LincolnPuzey LincolnPuzey deleted the remove_watchdog_gevent branch January 18, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants