Content Comments #5584
Merged
Content Comments #5584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds button for comments to pointer. Adds logic to generate a content reference point.
Made changes for dom and translation services for easier usage considering types. trans_choice updated to allow default count replacement data as per Laravel's default behaviour.
Also added archived property, to be added.
|
Hi! Could you please clarify if this feature will be implemented, and if so, when? We're evaluating documentation apps, and this is the only feature preventing us from choosing BookStack. |
Member
Author
|
@MfeaR This is a work in progress attempt at a feature. My aim is for this to be in the next feature release (so maybe late May or June) but can't promise anything. |
Started support for editor view. Moved comment elements to be added relative to content area instad of specific target reference element. Added relocating on screen size change.
Handles only display and handling references when they're in the active tab, while handling proper removal when made not visible.
- Added reference indicator to comment create form. - Added remove action. - Extracted reference text to translations. - Changed reference hash to be text-based instead of HTML based. - Added reference display for newly added comments. - Handled reference marker delete on comment delete.
Also added default non-clickable styles for scenarios for references which don't have an active content link.
- Migrated toolbox component to TS - Aligned how custom event types are managed - Fixed PHP use of content_ref where not provided
|
Hi - thank you for implementing this feature. One bug I've discovered is that after a comment is created, if you edit the comment, the reference link breaks, so the comment is no longer attached to the inline selection that started it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1265
Todo
Option for controlling displayMD editor display?