Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

New TestBed App and multiple bug fixes/cleanups #295

Merged
Boris-Em merged 17 commits into from
Jul 21, 2017
Merged

New TestBed App and multiple bug fixes/cleanups #295

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
59f25dd
Add encoder/decoder for BEMLineGraph properties
mackworth Mar 18, 2017
9bfe179
Add Types to all Arrays
mackworth Mar 18, 2017
7823735
Create new TestBed app to manipulate almost all parameters
mackworth Mar 19, 2017
7dc9f3a
Add colors, gradients, and alphas to TestBed
mackworth Mar 26, 2017
78c8cac
Fix assorted bugs in BEMSimpleLineGraph, especially null-data related
mackworth Mar 26, 2017
a10ad12
Allow use on iPhone and Split View
mackworth Mar 26, 2017
1169854
Fix bug with TouchLineInput color (doesn't change after initial setting)
mackworth Mar 26, 2017
019aa1e
Bug fixes:
mackworth Mar 28, 2017
0e33b98
Requested changes to PR 3295
mackworth May 14, 2017
c107658
Further fixes for more substantive comments on PR #295
mackworth May 14, 2017
e69998a
Add "Graph" button to Compact devices
mackworth May 14, 2017
212058f
Update .travis.yml
Boris-Em May 14, 2017
3dd033d
Remove unuseful breaking test
Boris-Em May 14, 2017
b2aff57
Merge pull request #1 from Boris-Em/PR295
mackworth May 15, 2017
fa2c33e
Fix space nit in comment
mackworth Jul 8, 2017
2072327
Merge remote-tracking branch 'origin/feature' into feature
mackworth Jul 8, 2017
e1c6fd6
Ensure circleDots always same length as dataPoints
mackworth Jul 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Classes/BEMSimpleLineGraphView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,10 @@ IB_DESIGNABLE @interface BEMSimpleLineGraphView : UIView <UIGestureRecognizerDel
@return The minimum value of the Y-Axis. */
- (CGFloat)minValueForLineGraph:(BEMSimpleLineGraphView *)graph;

/** Optional method to set the average value for the Average line. If not implemented, the value will be the average point of the graph.
@param graph The graph object requesting the minimum value.
Copy link
Owner

@Boris-Em Boris-Em May 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment for the graph parameter is not correct.

@return The average value of the Y-Axis. */
- (CGFloat)averageValueForLineGraph:(BEMSimpleLineGraphView *)graph;

/** Optional method to control whether a label indicating NO DATA will be shown while number of data is zero
@param graph The graph object for the NO DATA label
Expand Down Expand Up @@ -516,7 +520,7 @@ IB_DESIGNABLE @interface BEMSimpleLineGraphView : UIView <UIGestureRecognizerDel
@param graph The graph object requesting the padding value.
@param popupView The popup view owned by the graph that needs to be modified
@param index The index of the element associated with the popup view */
- (void)lineGraph:(BEMSimpleLineGraphView *)graph modifyPopupView:(UIView *)popupView forIndex:(NSUInteger)index __unavailable;
- (void)lineGraph:(BEMSimpleLineGraphView *)graph modifyPopupView:(UIView *)popupView forIndex:(NSUInteger)index;
Copy link
Collaborator

@Sam-Spencer Sam-Spencer Jun 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential misunderstanding here... why has this been marked as available again?

Copy link
Author

@mackworth mackworth Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, never saw it as unavailable. Why was it taken out? How are you supposed to use the custom Popup if it stays the same on every point?



//----- TOUCH EVENTS -----//
Expand Down
Loading