Skip to content

MIM-380: Handle more work orders#254

Merged
henrikhenrikpersson merged 4 commits intomainfrom
feature/mim-380-anpassa-onecore-till-att-skapa-arenden-i-lagenhet
Feb 24, 2025
Merged

MIM-380: Handle more work orders#254
henrikhenrikpersson merged 4 commits intomainfrom
feature/mim-380-anpassa-onecore-till-att-skapa-arenden-i-lagenhet

Conversation

@henrikhenrikpersson
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Feb 17, 2025

Copy link
Contributor

@johanneskarlsson johanneskarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Bravo!

Comment on lines +397 to +399
// Filter out workOrders that are not handled by onecore
const onecoreWorkOrderRequests = Rows.filter((workOrder: any) =>
['TV', 'BWC', 'KÖ'].includes(workOrder.LocationCode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det här känns ju egentligen inte nödvändigt, men kanske bra att ha?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nej sant, kanske värt att ta bort?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jag fixar det i #255

ctx.body = {
message: `Work order created`,
message: `Work orders created`,
// TODO better handling/response when there is an error with creating one or more work orders in the batch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@henrikhenrikpersson henrikhenrikpersson merged commit 8a92789 into main Feb 24, 2025
1 check passed
@henrikhenrikpersson henrikhenrikpersson deleted the feature/mim-380-anpassa-onecore-till-att-skapa-arenden-i-lagenhet branch February 24, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants