Feat: UTH-216 Show Error Message when no Valid Housing Contract can be Found#260
Merged
mittistormen merged 3 commits intomainfrom Mar 10, 2025
Merged
Conversation
Contributor
mittistormen
commented
Mar 4, 2025
mittistormen
commented
- Adapter can now return no-valid-housing-contract
- Route now returns error corresponding to the RFC 7807 standard
* Adapter can now return no-valid-housing-contract * Route now returns error corresponding to the RFC 7807 standard
mittistormen
changed the title
sandnuggah
approved these changes
Mar 5, 2025
src/services/lease-service/index.ts
Outdated
Comment on lines
+468
to
+469
| // reason: 'no-valid-housing-contract', | ||
| // error: 'No valid housing contract found', |
Contributor
There was a problem hiding this comment.
Are these comments here as a reminder or should they be removed?
sandnuggah
approved these changes
Mar 10, 2025
Contributor
sandnuggah
left a comment
sandnuggah
left a comment
There was a problem hiding this comment.
Well done, looks great!
mittistormen
deleted the
feat/uth-214-new-rules-for-current-housing-contract
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.