MIM-504: fetch leases by property id from leasing#291
Merged
momentiris merged 11 commits intomainfrom May 14, 2025
Merged
Conversation
Contributor
|
Would be nice with a test for the endpoint? 🧪 |
Contributor
Author
henrikhenrikpersson
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint to fetch leases by property id from leasing.
Adapter function already existed, so I just added the endpoint.
Note
In order to add swagger docs for this endpoint to consume from property-tree (and possibly others in the future) I added a Lease zod schema.
This endeavor brought to my attention what I believe are problems with the Lease type from onecore-types. It has circular dependencies which I don't think makes sense. Lease.tenants is a list of Contact, which in turn has a list of Lease on them.
So the schema I made skips the recursive properties on lease.