Feature/AVTAL-84: visa avtal som inte signerats ännu pa mimer.nu#388
Closed
lalmqvist wants to merge 61 commits intoepic/avtal-49-epic-borja-anvanda-tenfast-for-avtalfrom
Closed
Conversation
* Feat:AVTAL-22 Create Parking Space in Tenfast When crating a parking space lease i XPand, it should also be created in tenfast * Getting the rental object from tenfast to get ID * Getting or creating a tenant in tenfast * Getting the correct template from tenfast * Creatig a lease
* Feat:AVTAL-22 Create Parking Space in Tenfast When crating a parking space lease i XPand, it should also be created in tenfast * Getting the rental object from tenfast to get ID * Getting or creating a tenant in tenfast * Getting the correct template from tenfast * Creatig a lease
* wip * Remove unused Invoice and InvoiceRow properties, and related code * Refactor and update * Add tests for tenfast adapter and getInvoiceDetails service function * Remove accidentally commited test code * Set invoiceRowText to null when transforming and add comment about why * Remove console.log from test * Put back some Invoice and InvoiceRow properties that were being used * Fix missing mock in test * Remove unused imports * Remove and add comments about Invoice properties * Move headers into makeTenfastRequest * Remove unnecessary utilities mock * Pass functions to describe instead of strings * Use assert instead of if * Return instead of throwing if schema parse fails * Use factories for mocks * Remove unused gql import --------- Co-authored-by: Henrik Persson <henrik.persson@iteam.com>
* wip scaffold tenfast lease * end date is nullable * remove unused code * add comments to lease type * internal-portal: remove old unused pages * remove rentalProperty, rentInfo and address from lease type Pretty sure these arent used anywhere * wip filter leases * what about this lease status calculation? * new proto lease routes * its leaseid * revise filters again * modify filters * move lease route tests to routes * comment out old lease routes * move lease and applicant adapter fns to files * core: clean up some param usage * core: rename stuff to getLeasesByContactCode and getLeasesByRentalObjectCode * core: move lease routes to lease file * adapt existing lease tests to new endpoints * revise filtering with tests * test include contacts * move lease param schemas to types * core: use new lease endpoint query params * core: adapt lease routes docs and tests * core: add route tests for get contact by contact code * core: lease route rentalPropertyId => rentalObjectCode * core: update get lease param usage * add todo * fix ts error * leasing: fix rental object tests * leasing: add hyresobjekt external id to lease return object * leasing: remove unused file * leasing: move tenfast schemas to lease service * core: fix broken tests * core: get leases through contact code instead * core, leasing: remove contacts by pnr route * leasing: remove now unused xpand lease code * leasing:remove more legacy routes * types: remove comments on lease type * internal-portal: remove adress col * leasing: remove seemingly unused tenfast schemas * leasing: update fields on the tenfast lease model * remove commented code * leasing: just extract lease number for now * types: fix schema * remove duplicate import * move stuff into tenfast factory * leasing: adjust and remove some schema fields from api testing * gen types * prop-tree, leasing: ts fixup * types: fix query param schema * prop-tree: use filters
* leasing: scaffold tenfast create/delete invoice rows * leasing: add basic tests for route + adapter * economy: doc typo * add some tenfast envs
Rent should be retrieved from Tenfast instead of XPand * Get Rent by RentalObjectCode from Tenfast * Get Rent by RentalObjectCodes (bulk) from Tenfast * Added Rent from tenfast-adapter to RentalObjects * Added routes to get rents for multiple RentalObjectCodes * Created a new model for holding Rent and RentRows for RentalObjects "RentalObjectRent" and "RentalObjectRentRow" * Removed code to get rent from XPand
* core,leasing: scaffold invoice rows in core + pluralize route name * require some fields * core, leasing: require article and use schema for yyyy-mm tenfast date format * wip get articles * leasing, core: rename invoice row to lease row in onecore scope * core,leasing: fix article tests * core, leasing: create rent row returns null * core, leasing: put rent article and rent row in onecore types * core, leasing: article -> rentArticle * core, leasing: rentarticle is just anything for now * cleanup * revert economy schema change * remove comments * types, core, leasing: share request schema * fix tests * prettier * prettier * prettier * remove rent article routes * rename rent row to lease rent row * api types * prettier * refactor to home insurance route * leasing: configure article id and amount for home insurance * envs * sanity check current lease before adding insurance * gen types * remove unused type
…#280) * Feat: AVTAL-71 Choose Template From Rental Object When Creating Lease When a new lease is created, we need to get the template from the rental object in tenfast instead
* core,leasing: scaffold get home insurance * core: add route for fetchin homei nsurance offer * core: rename to monthlyAmount * core, leasing: get tenfast lease by external id * core: rename get create insurance fn * core, leasing: send from date when creating home insurance * idk why that diff is there * why is this diff here * core: missing tests * core, leasing: core decides amount for adding insurance * leasing: fix env * core, leasing: just use create/delete lease home insurance altogether * leasing: use right value for deletion * core, leasing: cancel home insurance by replacing existing * leasing: replace existing home insurance on create and delete * core, leasing: put schemas in types and test endpoint contract * leasing: basic tests for updateLeaseInvoiceRows * leasing: lease invoice row dates now yyyy-mm-dd * remove todos
* Feat: AVTAL-80 Remove Option To Include RentRows On Lease * When getting a lease from Tenfast, RentRows should always be included. * Options to "includeRentInfo" has been removed * Also removed an unused route in leasing that retrieved leases from xpand
…-terminated Fix/missing status prel terminated
…o feature/avtal-84-visa-om-avtal-inte-signerats-annu-pa-mimernu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.