Merged
Conversation
554e26c to
c192fe9
Compare
Penguin is an Opposing Force multiplayer weapon (snark reskin) that was missing from jk_botti. Add weapon definition, fire delay, monster entity detection, and enemy search skip logic, mirroring snark behavior. Penguin shares weapon ID 26 with HL:Arena's 9mmsilenced. Fix GetWeaponSelect to prefer entries matching the active submod when multiple weapons share the same ID.
c192fe9 to
891d261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ID 26 collision note
Penguin (OP4) and 9mmsilenced (HL:Arena) both use weapon ID 26. This is correct — the engine assigns the same ID slot to different weapons in different mods. They never coexist at runtime since
supported_submodsfilters them (WEAPON_SUBMOD_OP4vsWEAPON_SUBMOD_ARENA). Penguin is not present in HL:Arena.GetWeaponSelectis updated to be submod-aware so it returns the correct entry for the active mod.Test plan
make testwith i686-linux-gnu toolchain)