Working block enter notifications #2639
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn emit_annotated_block(&mut self, v: &str) { | ||
| self.emit_string_literal(v); | ||
| let mut function_name: [u8; 1024] = [0; 1024]; | ||
| function_name.copy_from_slice(v.as_bytes()); | ||
| // null terminate the vec in case its too long | ||
| function_name[std::cmp::min(v.len(), 1023)] = 0; | ||
|
|
||
| let mut block_name: [u8; 1024] = [0; 1024]; | ||
| block_name.copy_from_slice(v.as_bytes()); | ||
| // null terminate the vec in case its too long |
There was a problem hiding this comment.
The new emit_annotated_block allocates two 1024‑byte buffers and fills them with function_name.copy_from_slice(v.as_bytes()) and block_name.copy_from_slice(v.as_bytes()). copy_from_slice requires that the source and destination slices have exactly the same length, so any annotation label shorter than 1024 bytes will cause an immediate panic during code generation. Since all the added test annotations are much shorter than 1024, any annotated statement now crashes the compiler before bytecode is produced. Use a bounded copy (e.g. slicing the destination to ..v.len()) instead of copy_from_slice on the whole array.
Useful? React with 👍 / 👎.
No description provided.