fix: select earliest successful LLM call by lexicographic request_id order #2692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
This PR fixes #2451
Summary
Updated LLM call selection logic to correctly pick the earliest successful call by lexicographic
HttpRequestIdordering. This ensures deterministic selection when multiple successful calls exist.Changes
This PR addresses an issue where the code prioritized completion time instead of lexicographically earliest ulid uuid.
is_success = trueDetails
request_id.to_string()lexicographically (sinceHttpRequestIdlacksOrd)cargo test -p baml-runtime -qNote
Refactors LLM call selection to pick the earliest successful call by lexicographic HttpRequestId and marks only that call as selected, with new tests covering success-vs-failure and ordering.
CallCandidateto gather data for eachrequest_id.request_id.to_string()lexicographically, select the first; mark only that call asselectedacrossBasicandStreamkinds.test_selected_call_prefers_success_over_failureandtest_selected_call_chooses_earlier_success_if_last_failedto verify selection behavior.Written by Cursor Bugbot for commit 9a3143e. This will update automatically on new commits. Configure here.