Open
Conversation
MakaryHryshkin
requested review from
ANavakahtsky,
ArtemySinitsa and
JustWalters
JustWalters
approved these changes
Sep 21, 2021
| * @returns {Promise} | ||
| */ | ||
|
|
||
| async function syncDependantIndexes(sourceDoc, esOptions, opType) { |
There was a problem hiding this comment.
Should the file name be changed to use Indexes instead of Indicies?
lib/index.js
Outdated
Comment on lines
+73
to
+78
| options.syncDependantIndexes = [options.syncType].includes( | ||
| SyncType.DEPENDANT_INDEXES, | ||
| SyncType.CURRENT_AND_DEPENDANT_INDEXES | ||
| ); | ||
|
|
||
| options.syncCurrentIndex = [options.syncType].includes( |
There was a problem hiding this comment.
These includes look backwards. I'd expect options.syncType to be the argument.
| doc.emit("es-indexed", err); | ||
| doc.constructor.emit("es-indexed", err); | ||
|
|
||
| if (err) { |
There was a problem hiding this comment.
Do we need this if inside the catch?
| * @param {Object} doc | ||
| */ | ||
| async function postSave(doc) { | ||
| async function postSave(doc, next) { |
There was a problem hiding this comment.
Since we have the jsdoc comments, could you add next here and for postRemove?
|
|
||
| if (!esOptions.filter || esOptions.filter(doc)) { | ||
| if (esOptions.syncDependantIndexes && !data.wasNew) { | ||
| await syncDependantIndexes( |
There was a problem hiding this comment.
We're try/catching this function in postRemove. Should we be doing the same here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new functionality of syncing the entities of dependant elasticsearch indices