Merged
Conversation
_This is a preliminary PR before proposing some more extensive changes to the workflow._ This commit: 1. Adds the `pull_request` trigger to ensure that pull requests from outside contributors get evaluated via CI. 2. Ensures all steps have a name. 3. Removes the redundant job `if` condition as GHA natively supports the `ci skip` annotation, so there is no need for the condition. 4. Removes the redundant `fail-fast: true`, as `true` is the default for `fail-fast`. 5. Standardizes on 4-space indentation as per gmazzap's preference as expressed in #118 (comment) Note: the industry standard for YAML files is two space indentation, which is what I would prefer. However, if the file uses 4-space indentation, let's at least do so consistently and not only in the job, but not in the other keys.
gmazzap
approved these changes
Dec 2, 2025
Contributor
|
Thanks @jrfnl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preliminary PR before proposing some more extensive changes to the workflow.
This commit:
pull_requesttrigger to ensure that pull requests from outside contributors get evaluated via CI.ifcondition as GHA natively supports theci skipannotation, so there is no need for the condition.fail-fast: true, astrueis the default forfail-fast.Note: the industry standard for YAML files is two space indentation, which is what I would prefer. However, if the file uses 4-space indentation, let's at least do so consistently and not only in the job, but not in the other keys.