Skip to content

cleaning ereg#125

Merged
neuronflow merged 4 commits intomainfrom
retire_ereg
Apr 22, 2025
Merged

cleaning ereg#125
neuronflow merged 4 commits intomainfrom
retire_ereg

Conversation

@neuronflow
Copy link
Collaborator

Signed-off-by: neuronflow florian.kofler@tum.de

Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow neuronflow requested a review from Copilot April 17, 2025 10:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the experimental eReg registration functionality from the codebase and cleans up associated references.

  • Removed the TestEregRegistrator and associated eReg tests.
  • Removed eReg dependency and its extras from pyproject.toml.
  • Removed the eReg module and its import logic.
  • Updated the example usage and documentation to remove eReg references.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_registrators.py Removed tests for eRegRegistrator
pyproject.toml Removed eReg dependency and updated the extras list
example/example_modality_centric_preprocessor.py Removed commented-out usage of eRegRegistrator
brainles_preprocessing/registration/eReg/eReg.py Removed the eReg module code
brainles_preprocessing/registration/init.py Removed conditional import and warning for eRegRegistrator
README.md Updated registration section to remove reference to eReg

@neuronflow
Copy link
Collaborator Author

with some sad feelings we are retiring ereg support. Are there more files / dependencies that need to be updated @sarthakpati ?

@neuronflow neuronflow requested a review from MarcelRosier April 17, 2025 14:17
@MarcelRosier
Copy link
Collaborator

Copy link
Collaborator

@MarcelRosier MarcelRosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove from docs as mentioned above

Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
Copy link
Collaborator Author

@sarthakpati elastix and greedy also need to be mentioned in the documentation, see:
afcd06d

@neuronflow neuronflow merged commit a632e39 into main Apr 22, 2025
4 checks passed
@neuronflow neuronflow deleted the retire_ereg branch April 22, 2025 14:04
@sarthakpati
Copy link
Contributor

@sarthakpati elastix and greedy also need to be mentioned in the documentation, see: afcd06d

Do you think you could add that in? I'm happy to review.

@neuronflow
Copy link
Collaborator Author

neuronflow commented Apr 22, 2025

@sarthakpati elastix and greedy also need to be mentioned in the documentation, see: afcd06d

@MarcelRosier could you please create such a PR and request @sarthakpati for review? :)

see: https://github.com/BrainLesion/preprocessing/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants