Conversation
Signed-off-by: neuronflow <florian.kofler@tum.de>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the experimental eReg registration functionality from the codebase and cleans up associated references.
- Removed the TestEregRegistrator and associated eReg tests.
- Removed eReg dependency and its extras from pyproject.toml.
- Removed the eReg module and its import logic.
- Updated the example usage and documentation to remove eReg references.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_registrators.py | Removed tests for eRegRegistrator |
| pyproject.toml | Removed eReg dependency and updated the extras list |
| example/example_modality_centric_preprocessor.py | Removed commented-out usage of eRegRegistrator |
| brainles_preprocessing/registration/eReg/eReg.py | Removed the eReg module code |
| brainles_preprocessing/registration/init.py | Removed conditional import and warning for eRegRegistrator |
| README.md | Updated registration section to remove reference to eReg |
|
with some sad feelings we are retiring ereg support. Are there more files / dependencies that need to be updated @sarthakpati ? |
|
should also be removed from the docs: |
MarcelRosier
left a comment
There was a problem hiding this comment.
Also remove from docs as mentioned above
Signed-off-by: neuronflow <florian.kofler@tum.de>
|
@sarthakpati elastix and greedy also need to be mentioned in the documentation, see: |
Do you think you could add that in? I'm happy to review. |
@MarcelRosier could you please create such a PR and request @sarthakpati for review? :) |
Signed-off-by: neuronflow florian.kofler@tum.de