Added a simple CLI using typer#113
Merged
MarcelRosier merged 8 commits intoBrainLesion:mainfrom Mar 20, 2025
Merged
Conversation
Collaborator
MarcelRosier
left a comment
MarcelRosier
left a comment
There was a problem hiding this comment.
Needs formatting, our bot sadly does not work for PRs from forks
brainles_preprocessing/cli.py
Outdated
|
|
||
|
|
||
| def version_callback(value: bool): | ||
| __version__ = "0.0.0-dev" # this needs to be fixed |
Collaborator
There was a problem hiding this comment.
should this be fixed before merging?
Contributor
Author
There was a problem hiding this comment.
I have no idea. How can someone get the current __version__ information from this package - perhaps we can use the same mechanism here?
If there is no such mechanism, then it should be part of a different PR.
Ref: https://stackoverflow.com/questions/458550/standard-way-to-embed-version-into-python-package
Collaborator
There was a problem hiding this comment.
I think you can just use this:
from importlib.metadata import version
__version__ = version("brainles_preprocessing")
Contributor
Author
|
BTW, I think the linter workflow is broken, because I have done the (C:\Projects\preprocessing\venv) PS C:\Projects\preprocessing> black .
reformatted brainles_preprocessing\cli.py
reformatted brainles_preprocessing\preprocessor.py
All done! ✨ 🍰 ✨
2 files reformatted, 33 files left unchanged. |
MarcelRosier
approved these changes
Mar 20, 2025
Collaborator
|
Will investigate the linter job separately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112