153 bug defaultvalue for padding when registering without skull stripping seems to be off#158
Merged
neuronflow merged 3 commits intomainfrom Aug 27, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where default padding values during image registration were causing artifacts when images weren't normalized. The fix sets the default padding value to the minimum value of the moving image instead of using 0, which better represents the background when working with non-normalized images.
- Updated ANTs and NiftyReg registration methods to use minimum image value as default padding
- Modified shell scripts to accept and use the new padding value parameter
- Added automatic padding value calculation based on moving image minimum
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| brainles_preprocessing/registration/ANTs/ANTs.py | Added automatic defaultvalue setting to minimum of moving image and refactored to use transform method |
| brainles_preprocessing/registration/niftyreg/niftyreg.py | Added padding value calculation and parameter passing to shell scripts |
| brainles_preprocessing/registration/niftyreg/niftyreg_scripts/rigid_reg.sh | Updated to accept and use padding value parameter |
| brainles_preprocessing/registration/niftyreg/niftyreg_scripts/transform.sh | Updated to accept and use padding value parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
neuronflow
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue arises when the registrations lead to out-of-view voxels that will be filled with a default value (by default, 0). However, if the image is not normalised, 0 does not correspond to the background channel, leading to artefacts.
As a solution, we set the default padding value to the minimum of the moving image - this seems to fix the issue. We will have to monitor if this causes issues elsewhere.
As of now, this fix is only implemented for ANTs and niftyreg.