Draft
Conversation
Collaborator
|
Supporting higher definition images would be great! Do you plan on continuing work on improving this, or are you okay with letting someone else take over? |
Mystin
added a commit
to Mystin/LEGUP
that referenced
this pull request
Feb 18, 2026
Merge Pull Request Bram-Hub#897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The icons do not look particularly good on high resolution displays, especially the ones on the landing window. These icons are scaled from 96x96 to 100x100, and it creates blurring and pixelation. I have added support for antialiased SVG icon rendering in the class SVGIcon, which is only around 300 lines, making it relatively maintainable. Vectorizing the existing set of icons is time consuming, so I have done it on two icons just to show an example.
Type of change
How Has This Been Tested?
To test the code, simply run the application and observe how the icons have smooth and crisp edges. The code can be affected by malformed input, but in such a case it will print errors and let the application run without icons.
Checklist: