Skip to content

Oskardev#940

Merged
jadeandtea merged 10 commits intoBram-Hub:devfrom
NordLee:oskardev
Mar 10, 2026
Merged

Oskardev#940
jadeandtea merged 10 commits intoBram-Hub:devfrom
NordLee:oskardev

Conversation

@NordLee
Copy link
Collaborator

@NordLee NordLee commented Nov 14, 2025

Description

Updated javadocs that were generating errors.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

NordLee and others added 10 commits October 24, 2025 16:30
# Conflicts:
#	.github/workflows/publish-javadoc.yml
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipElementView.java
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipExporter.java
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipImporter.java
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipView.java
#	src/test/java/puzzles/shorttruthtable/rules/BiconditionalCaseRuleTest.java
#	src/test/java/puzzles/shorttruthtable/rules/OrIntroductionTest.java
This reverts commit 61d27f5, reversing
changes made to 7b9396e.
This reverts commit 15f0f29.
# Conflicts:
#	.github/workflows/publish-javadoc.yml
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipElementView.java
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipExporter.java
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipImporter.java
#	src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipView.java
#	src/test/java/puzzles/shorttruthtable/rules/BiconditionalCaseRuleTest.java
#	src/test/java/puzzles/shorttruthtable/rules/BiconditionalContradictionRuleTest.java
#	src/test/java/puzzles/shorttruthtable/rules/OrIntroductionTest.java
@jadeandtea jadeandtea merged commit 0cae662 into Bram-Hub:dev Mar 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants