Skip to content

Fixed hover sticking#957

Merged
jadeandtea merged 4 commits intoBram-Hub:devfrom
Mystin:dev
Feb 26, 2026
Merged

Fixed hover sticking#957
jadeandtea merged 4 commits intoBram-Hub:devfrom
Mystin:dev

Conversation

@Mystin
Copy link
Collaborator

@Mystin Mystin commented Feb 3, 2026

Description

Made ElementController's mouseEntered call mouseMoved rather than using duplicate code, and changed the condition in mouseExited to check for elements already being highlighted rather than elements under the cursor after it has already exited.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Visual confirmation.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Mystin and others added 2 commits February 2, 2026 12:35
Removed lots of duplicate code by having mouseEntered call mouseMoved for hover assignments, and made mouseExited look if any elements are currently hovered, rather than for elements currently under cursor.
@jadeandtea
Copy link
Collaborator

Looks like the issue still persists when dragging the mouse. Should be a simple fix?

Mystin and others added 2 commits February 10, 2026 16:52
Pulled hover update code into dedicated function and made mouseDragged also call the function so that the hover behavior is as expected while mouse is being dragged.
@jadeandtea jadeandtea merged commit 3a253be into Bram-Hub:dev Feb 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants