Merged
Conversation
Removed lots of duplicate code by having mouseEntered call mouseMoved for hover assignments, and made mouseExited look if any elements are currently hovered, rather than for elements currently under cursor.
Collaborator
|
Looks like the issue still persists when dragging the mouse. Should be a simple fix? |
Pulled hover update code into dedicated function and made mouseDragged also call the function so that the hover behavior is as expected while mouse is being dragged.
jadeandtea
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made ElementController's mouseEntered call mouseMoved rather than using duplicate code, and changed the condition in mouseExited to check for elements already being highlighted rather than elements under the cursor after it has already exited.
Type of change
How Has This Been Tested?
Visual confirmation.
Checklist: