Goal condition check refactoring and tests for all existing conditions#966
Merged
Budderfriend merged 6 commits intoBram-Hub:goalConditionfrom Mar 17, 2026
Merged
Conversation
Most of this will be removed or reworded into more formal documentation, this is just an organization of thoughts
…w helper functions. Added documentation for the helper functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The IsPuzzleComplete() function in the Puzzle class has been rewritten alongside several helper functions in order to make the code more readable as well as make it much easier to add new goal conditions in the future. Tests have been written for all existing goal conditions.
Type of change
Checklist: