Skip to content

fix build ios project name #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix build ios project name #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf5a387
fix build ios project name
Leo1305Pineda Mar 10, 2020
2724466
Merge branch 'master' into fix-build-ios-project-name
Leo1305Pineda Oct 12, 2020
587f60b
Merge branch 'master' into fix-build-ios-project-name
Leo1305Pineda Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/scripts/ios/updateAssociatedDomains.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@

for (let i = 0; i < BUILD_TYPES.length; i++) {
const buildType = BUILD_TYPES[i];
const projectName = preferences.projectName.replace( /[\r\n]+/gm, '' ).replace(/(^[\s]+|[\s]+$)/g, '');
const plist = path.join(
preferences.projectRoot,
"platforms",
"ios",
preferences.projectName,
projectName,
`Entitlements-${buildType}.plist`
);
files.push(plist);
Expand Down
5 changes: 2 additions & 3 deletions src/scripts/ios/updatePlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@

// updates the platforms/ios/app.plist file with branch settings within app/config.xml
function addBranchSettings(preferences) {
const filePath = `platforms/ios/${preferences.projectName}/${
preferences.projectName
}-Info.plist`;
const projectName = preferences.projectName.replace( /[\r\n]+/gm, '' ).replace(/(^[\s]+|[\s]+$)/g, '');
const filePath = `platforms/ios/${projectName}/${projectName}-Info.plist`;
let xml = readPlist(filePath);
let obj = convertXmlToObject(xml);

Expand Down