Skip to content

Commit 5d963b6

Browse files
authored
Handle network service deallocation better. (#802)
1 parent 3037e3f commit 5d963b6

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

Branch-SDK/Branch-SDK/BNCURLBlackList.m

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ - (instancetype) init {
5252
return self;
5353
}
5454

55+
- (void) dealloc {
56+
[self.networkService cancelAllOperations];
57+
self.networkService = nil;
58+
}
59+
5560
- (void) setBlackList:(NSArray<NSString *> *)blackList {
5661
@synchronized (self) {
5762
_blackList = blackList;
@@ -132,6 +137,7 @@ - (void) refreshBlackListFromServerWithCompletion:(void (^) (NSError*error, NSAr
132137
^(id<BNCNetworkOperationProtocol> operation) {
133138
[self processServerOperation:operation];
134139
if (completion) completion(self.error, self.blackList);
140+
[self.networkService cancelAllOperations];
135141
self.networkService = nil;
136142
}
137143
];

Branch-SDK/Branch-SDK/Networking/BNCServerInterface.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ - (instancetype) init {
3939
return self;
4040
}
4141

42+
- (void) dealloc {
43+
[self.networkService cancelAllOperations];
44+
self.networkService = nil;
45+
}
46+
4247
+ (NSArray/**<SecKeyRef>*/*) publicSecKeyRefs {
4348

4449
#pragma clang diagnostic push

0 commit comments

Comments
 (0)