SDK-842 use modern dictionary syntax

Author: echo-branch

Branch-SDK-Tests/BNCDeviceInfoTests.m

@@ -136,12 +136,12 @@ - (void)testLocalIPAddress {
 - (void)testV2Dictionary {
     NSDictionary *dict = [self.deviceInfo v2dictionary];
     XCTAssertNotNil(dict);
-    XCTAssertNotNil([dict objectForKey:@"brand"]);
-    XCTAssertNotNil([dict objectForKey:@"os"]);
-    XCTAssertNotNil([dict objectForKey:@"sdk"]);
-    XCTAssertNotNil([dict objectForKey:@"sdk_version"]);
+    XCTAssertNotNil(dict[@"brand"]);
+    XCTAssertNotNil(dict[@"os"]);
+    XCTAssertNotNil(dict[@"sdk"]);
+    XCTAssertNotNil(dict[@"sdk_version"]);
 
-    XCTAssertNil([dict objectForKey:@"disable_ad_network_callouts"]);
+    XCTAssertNil(dict[@"disable_ad_network_callouts"]);
 }
 
 @end

Branch-SDK-Tests/BNCDisableAdNetworkCalloutsTests.m

@@ -35,12 +35,12 @@ - (void)tearDown {
 - (void)testV2Dictionary {
     NSDictionary *dict = [[BNCDeviceInfo getInstance] v2dictionary];
     XCTAssertNotNil(dict);
-    XCTAssertNotNil([dict objectForKey:@"brand"]);
-    XCTAssertNotNil([dict objectForKey:@"os"]);
-    XCTAssertNotNil([dict objectForKey:@"sdk"]);
-    XCTAssertNotNil([dict objectForKey:@"sdk_version"]);
+    XCTAssertNotNil(dict[@"brand"]);
+    XCTAssertNotNil(dict[@"os"]);
+    XCTAssertNotNil(dict[@"sdk"]);
+    XCTAssertNotNil(dict[@"sdk_version"]);
 
-    XCTAssertTrue([dict objectForKey:@"disable_ad_network_callouts"]);
+    XCTAssertTrue(dict[@"disable_ad_network_callouts"]);
 }
 
 // check on V1 payload
@@ -52,7 +52,7 @@ - (void)testV1Payload {
     [interface updateDeviceInfoToMutableDictionary:tmp];
 
     XCTAssertNotNil(tmp);
-    XCTAssertTrue([tmp objectForKey:@"disable_ad_network_callouts"]);
+    XCTAssertTrue(tmp[@"disable_ad_network_callouts"]);
 }
 
 @end

Branch-SDK/Branch-SDK/BNCDeviceInfo.m

@@ -151,7 +151,7 @@ - (NSDictionary *)v2dictionary {
 
         BOOL disableAdNetworkCallouts = [BNCPreferenceHelper preferenceHelper].disableAdNetworkCallouts;
         if (disableAdNetworkCallouts) {
-            [dictionary setObject:[NSNumber numberWithBool:disableAdNetworkCallouts] forKey:@"disable_ad_network_callouts"];
+            dictionary[@"disable_ad_network_callouts"] = [NSNumber numberWithBool:disableAdNetworkCallouts];
         }
 
         if ([BNCPreferenceHelper preferenceHelper].isDebug) {