CORE-1198 rename some methods

Author: echo-branch

Branch-SDK/BNCURLFilter.h

@@ -17,20 +17,20 @@
 @interface BNCURLFilter : NSObject
 
 /**
- @brief         Checks if a given URL should be ignored (blacklisted).
+ @brief Checks if a given URL should be ignored.
 
- @param url     The URL to be checked.
- @return        Returns true if the provided URL should be ignored.
+ @param url The URL to be checked.
+ @return Returns true if the provided URL should be ignored.
 */
-- (BOOL) isBlackListedURL:(NSURL*_Nullable)url;
+- (BOOL) shouldIgnoreURL:(NSURL*_Nullable)url;
 
 /**
- @brief         Returns the pattern that matches a URL, if any.
+ @brief Returns the pattern that matches a URL, if any.
 
- @param url     The URL to be checked.
- @return        Returns the pattern matching the URL or `nil` if no patterns match.
+ @param url The URL to be checked.
+ @return Returns the pattern matching the URL or `nil` if no patterns match.
 */
-- (NSString*_Nullable) blackListPatternMatchingURL:(NSURL*_Nullable)url;
+- (NSString*_Nullable) patternMatchingURL:(NSURL*_Nullable)url;
 
 /// Refreshes the list of ignored URLs from the server.
 - (void) refreshBlackListFromServerWithCompletion:(void (^_Nullable) (NSError*_Nullable error, NSArray*_Nullable list))completion;

Branch-SDK/BNCURLFilter.m

@@ -14,7 +14,7 @@
 @interface BNCURLFilter () {
     NSArray<NSString*>*_blackList;
 }
-@property (strong) NSArray<NSRegularExpression*> *blackListRegex;
+@property (strong) NSArray<NSRegularExpression*> *ignoredURLRegex;
 @property (assign) NSInteger blackListVersion;
 @property (strong) id<BNCNetworkServiceProtocol> networkService;
 @property (assign) BOOL hasRefreshedBlackListFromServer;
@@ -46,7 +46,7 @@ - (instancetype) init {
     }
 
     NSError *error = nil;
-    _blackListRegex = [self.class compileRegexArray:self.blackList error:&error];
+    _ignoredURLRegex = [self.class compileRegexArray:self.blackList error:&error];
     self.error = error;
 
     return self;
@@ -60,7 +60,7 @@ - (void) dealloc {
 - (void) setBlackList:(NSArray<NSString *> *)blackList {
     @synchronized (self) {
         _blackList = blackList;
-        _blackListRegex = [self.class compileRegexArray:_blackList error:nil];
+        _ignoredURLRegex = [self.class compileRegexArray:_blackList error:nil];
     }
 }
 
@@ -90,21 +90,21 @@ - (void) setBlackList:(NSArray<NSString *> *)blackList {
     return array;
 }
 
-- (NSString*_Nullable) blackListPatternMatchingURL:(NSURL*_Nullable)url {
+- (NSString*_Nullable) patternMatchingURL:(NSURL*_Nullable)url {
     NSString *urlString = url.absoluteString;
     if (urlString == nil || urlString.length <= 0) return nil;
     NSRange range = NSMakeRange(0, urlString.length);
 
-    for (NSRegularExpression* regex in self.blackListRegex) {
+    for (NSRegularExpression* regex in self.ignoredURLRegex) {
         NSUInteger matches = [regex numberOfMatchesInString:urlString options:0 range:range];
         if (matches > 0) return regex.pattern;
     }
 
     return nil;
 }
 
-- (BOOL) isBlackListedURL:(NSURL *)url {
-    return ([self blackListPatternMatchingURL:url]) ? YES : NO;
+- (BOOL) shouldIgnoreURL:(NSURL *)url {
+    return ([self patternMatchingURL:url]) ? YES : NO;
 }
 
 - (void) refreshBlackListFromServer {

Branch-SDK/Branch.m

@@ -702,9 +702,9 @@ - (BOOL)handleDeepLink:(NSURL *)url sceneIdentifier:(NSString *)sceneIdentifier
     self.initializationStatus = BNCInitStatusUninitialized;
 
     NSString *blackListPattern = nil;
-    blackListPattern = [self.URLBlackList blackListPatternMatchingURL:url];
+    blackListPattern = [self.URLBlackList patternMatchingURL:url];
     if (!blackListPattern) {
-        blackListPattern = [_userURLBlackList blackListPatternMatchingURL:url];
+        blackListPattern = [_userURLBlackList patternMatchingURL:url];
     }
     if (blackListPattern) {
         self.preferenceHelper.blacklistURLOpen = YES;