CORE-1198 rename more methods

Author: echo-branch

Branch-SDK/BNCURLFilter.h

@@ -33,9 +33,9 @@
 - (NSString*_Nullable) patternMatchingURL:(NSURL*_Nullable)url;
 
 /// Refreshes the list of ignored URLs from the server.
-- (void) refreshBlackListFromServerWithCompletion:(void (^_Nullable) (NSError*_Nullable error, NSArray*_Nullable list))completion;
+- (void) updatePatternListWithCompletion:(void (^_Nullable) (NSError*_Nullable error, NSArray*_Nullable list))completion;
 
 /// Is YES if the listed has already been updated from the server.
-@property (assign, readonly) BOOL hasRefreshedBlackListFromServer;
-@property (strong) NSArray<NSString*>*_Nullable blackList;
+@property (assign, readonly) BOOL hasUpdatedPatternList;
+@property (strong) NSArray<NSString*>*_Nullable patternList;
 @end

Branch-SDK/BNCURLFilter.m

@@ -17,7 +17,7 @@ @interface BNCURLFilter () {
 @property (strong) NSArray<NSRegularExpression*> *ignoredURLRegex;
 @property (assign) NSInteger blackListVersion;
 @property (strong) id<BNCNetworkServiceProtocol> networkService;
-@property (assign) BOOL hasRefreshedBlackListFromServer;
+@property (assign) BOOL hasUpdatedPatternList;
 @property (strong) NSError *error;
 @property (strong) NSURL *blackListJSONURL;
 @end
@@ -28,7 +28,7 @@ - (instancetype) init {
     self = [super init];
     if (!self) return self;
 
-    self.blackList = @[
+    self.patternList = @[
         @"^fb\\d+:",
         @"^li\\d+:",
         @"^pdk\\d+:",
@@ -41,12 +41,12 @@ - (instancetype) init {
 
     NSArray *storedList = [BNCPreferenceHelper preferenceHelper].URLBlackList;
     if (storedList.count > 0) {
-        self.blackList = storedList;
+        self.patternList = storedList;
         self.blackListVersion = [BNCPreferenceHelper preferenceHelper].URLBlackListVersion;
     }
 
     NSError *error = nil;
-    _ignoredURLRegex = [self.class compileRegexArray:self.blackList error:&error];
+    _ignoredURLRegex = [self.class compileRegexArray:self.patternList error:&error];
     self.error = error;
 
     return self;
@@ -57,14 +57,14 @@ - (void) dealloc {
     self.networkService = nil;
 }
 
-- (void) setBlackList:(NSArray<NSString *> *)blackList {
+- (void) setPatternList:(NSArray<NSString *> *)blackList {
     @synchronized (self) {
         _blackList = blackList;
         _ignoredURLRegex = [self.class compileRegexArray:_blackList error:nil];
     }
 }
 
-- (NSArray<NSString*>*) blackList {
+- (NSArray<NSString*>*) patternList {
     @synchronized (self) {
         return _blackList;
     }
@@ -108,16 +108,16 @@ - (BOOL) shouldIgnoreURL:(NSURL *)url {
 }
 
 - (void) refreshBlackListFromServer {
-    [self refreshBlackListFromServerWithCompletion:nil];
+    [self updatePatternListWithCompletion:nil];
 }
 
-- (void) refreshBlackListFromServerWithCompletion:(void (^) (NSError*error, NSArray*list))completion {
+- (void) updatePatternListWithCompletion:(void (^) (NSError*error, NSArray*list))completion {
     @synchronized(self) {
-        if (self.hasRefreshedBlackListFromServer) {
-            if (completion) completion(self.error, self.blackList);
+        if (self.hasUpdatedPatternList) {
+            if (completion) completion(self.error, self.patternList);
             return;
         }
-        self.hasRefreshedBlackListFromServer = YES;
+        self.hasUpdatedPatternList = YES;
     }
 
     self.error = nil;
@@ -135,7 +135,7 @@ - (void) refreshBlackListFromServerWithCompletion:(void (^) (NSError*error, NSAr
         [self.networkService networkOperationWithURLRequest:request completion:
             ^(id<BNCNetworkOperationProtocol> operation) {
                 [self processServerOperation:operation];
-                if (completion) completion(self.error, self.blackList);
+                if (completion) completion(self.error, self.patternList);
                 [self.networkService cancelAllOperations];
                 self.networkService = nil;
             }
@@ -172,9 +172,9 @@ - (void) processServerOperation:(id<BNCNetworkOperationProtocol>)operation {
     NSNumber *blackListVersion = dictionary[@"version"];
     if (![blackListVersion isKindOfClass:NSNumber.class]) return;
 
-    self.blackList = blackListURLs;
+    self.patternList = blackListURLs;
     self.blackListVersion = [blackListVersion longValue];
-    [BNCPreferenceHelper preferenceHelper].URLBlackList = self.blackList;
+    [BNCPreferenceHelper preferenceHelper].URLBlackList = self.patternList;
     [BNCPreferenceHelper preferenceHelper].URLBlackListVersion = self.blackListVersion;
 }
 

Branch-SDK/Branch.m

@@ -676,13 +676,13 @@ - (void)addWhiteListedScheme:(NSString *)scheme {
 - (void)setBlackListURLRegex:(NSArray<NSString*>*)blackListURLs {
     @synchronized (self) {
         _userURLBlackList = [[BNCURLFilter alloc] init];
-        _userURLBlackList.blackList = blackListURLs;
+        _userURLBlackList.patternList = blackListURLs;
     }
 }
 
 - (NSArray<NSString *> *)blackListURLRegex {
     @synchronized (self) {
-        return _userURLBlackList.blackList;
+        return _userURLBlackList.patternList;
     }
 }
 
@@ -2212,8 +2212,8 @@ - (void)handleInitSuccessAndCallCallback:(BOOL)callCallback sceneIdentifier:(NSS
     }
     [self sendOpenNotificationWithLinkParameters:latestReferringParams error:nil];
 
-    if (!self.URLBlackList.hasRefreshedBlackListFromServer) {
-        [self.URLBlackList refreshBlackListFromServerWithCompletion:nil];
+    if (!self.URLBlackList.hasUpdatedPatternList) {
+        [self.URLBlackList updatePatternListWithCompletion:nil];
     }
 
     if (self.shouldAutomaticallyDeepLink) {