iOS Integration Validator 2.0 #1439
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,17 +150,37 @@ + (NSString *)defaultURIScheme { | |
|
|
||
| + (BOOL)compareUriSchemes : (NSString *) serverUriScheme { | ||
| NSArray *urlTypes = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleURLTypes"]; | ||
| return [self compareUriSchemes:serverUriScheme With:urlTypes]; | ||
| } | ||
|
|
||
| + (BOOL)compareUriSchemes:(NSString *)serverUriScheme With:(NSArray *)urlTypes { | ||
| NSString * serverUriSchemeWithoutSuffix ; | ||
|
|
||
| if ([serverUriScheme hasSuffix:@"://"]) { | ||
| serverUriSchemeWithoutSuffix = [serverUriScheme substringToIndex:[serverUriScheme length] - 3]; | ||
| } else { | ||
| serverUriSchemeWithoutSuffix = serverUriScheme; | ||
| } | ||
|
|
||
| for (NSDictionary *urlType in urlTypes) { | ||
|
|
||
| NSArray *urlSchemes = [urlType objectForKey:@"CFBundleURLSchemes"]; | ||
| for (NSString *uriScheme in urlSchemes) { | ||
| if ([uriScheme isEqualToString:serverUriSchemeWithoutSuffix]) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| + (BOOL)compareLinkDomain:(NSString *)serverLinkDomain { | ||
| NSArray *linkDomains = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"branch_universal_link_domains"]; | ||
|
|
||
| for (NSString *domain in linkDomains) { | ||
| if ([domain isEqualToString:serverLinkDomain]) { | ||
|
There was a problem hiding this comment. @sharath-branch linkdomains strings can have prefix There was a problem hiding this comment. This is checking only the info.plist actually and not the associated domains. We recommend adding the prefix |
||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharath-branch At line no. 162, if code returns from here, it will not check second and more
urlTypein arrayurlTypesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!