[In Progress] SDK - 2519 Open Request Input Params Refactor#1454
Open
NidhiDixit09 wants to merge 12 commits intomasterfrom
Open
[In Progress] SDK - 2519 Open Request Input Params Refactor#1454NidhiDixit09 wants to merge 12 commits intomasterfrom
NidhiDixit09 wants to merge 12 commits intomasterfrom
Conversation
…h is already removed.
…back with params.referringURL. They both are same.
urlString holds the same value as linkparams.referringURL. So removed urlString and adjusted other functions to use linkparams.referringURL instead.
* Fixed property type of linkParams (strong) and added code to initialize it. * Added encoding functions for class BranchOpenRequestLinkParams. * Fixed value passed to saveAppClipData. It should be local variable referringURL.
* Bug Fixes : SDK-2530 & SDK SDK-2532 - Fixed isLinkingRelatedRequest function to allow opens if tracking is disabled and spotlight identifier is present. - Fixed race condition for push notification on cold launch. * Removed extra comment. * Added unit test for isLinkingRelatedRequest function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2518 -- Code refactor to handle Preference Helper Race Conditions
https://branch.atlassian.net/browse/SDK-2518
Subtask -- SDK-2519 -- Open Request Refactor
https://branch.atlassian.net/browse/SDK-2519
Summary
** SDK will no longer save following values in preference helper -
These values will be stored in BranchOpenRequest object
A new class is added to encapsulate above variables.
** Removed universalLinkUrl and externalIntentURI. referringURL contains same values. So Request construction will use referringURL now.
** Remove appVersion property from preference helper. Its no longer used.
Type Of Change
Testing Instructions
cc @BranchMetrics/saas-sdk-devs for visibility.