[SDK-2527] Add request & response objects to the BranchLogCallback #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bredmond5
reviewed
Dec 9, 2024
bredmond5
reviewed
Dec 9, 2024
|
|
||
| if (self.logCallback) { | ||
|
|
||
| if (self.advancedLogCallback) { |
There was a problem hiding this comment.
@nsingh-branch Since advancedLogCallback is always non-null, its initialized in init, else if condition will never be executed.
There was a problem hiding this comment.
I removed the default init since it shouldn't be necessary to have both. All of the tests appear to be passing now.
There was a problem hiding this comment.
Did the new automation succeed as well?
gdeluna-branch
approved these changes
Dec 11, 2024
NidhiDixit09
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2427 -- Add request & response objects to the BranchLogCallback
Summary
Updates the BranchLogCallback to include the request and response objects themselves rather than just include the data in the log message.
Motivation
Make it easier to parse networking logs.
Type Of Change
Testing Instructions
Try out the new BranchLogCallback with the request and response. This is a breaking change since it adds new fields to the BranchLogCallback
cc @BranchMetrics/saas-sdk-devs for visibility.