Skip to content

Conversation

NidhiDixit09
Copy link
Collaborator

Reference

SDK-2530 -- Fix Init Race for Push notifications
https://branch.atlassian.net/browse/SDK-2530

SDK-2532 -- If tracking is disabled and app is launched via spotlight results, linking request is not sent.
https://branch.atlassian.net/browse/SDK-2532

Summary

Fixes :

  • Push notifications are handled via handlePushNotification API which is called inside didReceiveRemoteNotification. So initSessionWithLaunchOptions is updated to not to send and extra open and call callback if app is launched via push notification.
  • Fixed isLinkingRelatedRequest function to allow opens if tracking is disabled and spotlight identifier is present.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

  • Launch App via push notification and verify initsession callback is called only once ( cold launch app, warm launch + active app , warm launch + background app )
  • Disable tracking and launch app vi Spotlight results or any link having spotlight identifier and verify open request was sent.

cc @BranchMetrics/saas-sdk-devs for visibility.

Bug Fixes :
- Fixed isLinkingRelatedRequest function to allow opens if tracking is disabled and spotlight identifier is present.
- Fixed race condition for push notification on cold launch.
@NidhiDixit09 NidhiDixit09 merged commit 29294e2 into SDK-2519-OpenRequest Jan 31, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants