SDK-2533 Integration validator crash fix #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed function compareUriSchemes to handle empty strings * Added wrapper function for compareUriSchemes to make it testable. * Added unit test
NidhiDixit09
requested review from
gdeluna-branch,
nsingh-branch,
rob-gioia-branch and
sharath-branch
sharath-branch
approved these changes
Jan 9, 2025
rob-gioia-branch
approved these changes
Jan 9, 2025
sharath-branch
merged commit aa8ad49
into
integration-validator-2.0
9 of 10 checks passed
sharath-branch
added a commit
that referenced
this pull request
Jan 21, 2025
* integration-validator-2.0 * Removed file logger from tvOS * Added tvOS conditional headers * Change header to public to fix test failure * Fixed testbed * fix: PR changes * fix: testbed file visibility * SDK-2533 Integration validator crash fix (#1467) * Fixed function compareUriSchemes to handle empty strings * Added wrapper function for compareUriSchemes to make it testable. * Added unit test --------- Co-authored-by: ndixit-branch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2533 -- Integration Validator crashes if URI scheme is not set (null) in dashboard.
https://branch.atlassian.net/browse/SDK-2533
Related Github Issue - #1463
Summary
compareUriSchemesto handle empty stringscompareUriSchemesto make it testable.Type Of Change
Testing Instructions
Delete URI scheme from the branch dashboard for the app and run integration validator. It should not crash and display message for mismatch.
cc @BranchMetrics/saas-sdk-devs for visibility.