Skip to content

Conversation

NidhiDixit09
Copy link
Collaborator

Reference

SDK-2537 -- Fix enableLogging API error - Ambiguous use of 'enableLogging'
https://branch.atlassian.net/browse/SDK-2537

Summary

Following are two overloaded versions of static API enableLoggingAtLevel and both had the second param nullable attribute. This resulted in two methods with same name and same param.

+ (void)enableLoggingAtLevel:(BranchLogLevel)logLevel withCallback:(nullable BranchLogCallback)callback;
+ (void)enableLoggingAtLevel:(BranchLogLevel)logLevel withAdvancedCallback:(nullable  BranchAdvancedLogCallback)callback;

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

In a test app, call API Branch.enableLogging(at: .verbose). Compile app to see we no longer get Build error.

cc @BranchMetrics/saas-sdk-devs for visibility.

@NidhiDixit09 NidhiDixit09 merged commit db47af2 into master Jan 31, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants