Removed 'nullable' attribute of BranchAdvancedLogCallback param #1474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2537 -- Fix enableLogging API error - Ambiguous use of 'enableLogging'
https://branch.atlassian.net/browse/SDK-2537
Summary
Following are two overloaded versions of static API
enableLoggingAtLevel
and both had the second paramnullable
attribute. This resulted in two methods with same name and same param.Type Of Change
Testing Instructions
In a test app, call API
Branch.enableLogging(at: .verbose)
. Compile app to see we no longer get Build error.cc @BranchMetrics/saas-sdk-devs for visibility.