Release 3.12.1 Version and ChangeLog Updates.#1494
Merged
NidhiDixit09 merged 1 commit intomasterfrom May 20, 2025
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
This PR looks good overall. It properly updates the version number across all necessary files and adds an entry to the changelog. I have a small suggestion to improve the changelog entry.
Skipped files
BranchSDK.xcodeproj/project.pbxproj: Skipped file pattern
Comment on lines
+3
to
+5
| v.3.12.1 | ||
| - Fixed bug - SDK crashes when Meta AEM query param `al_applink_data` is empty. | ||
|
|
Contributor
There was a problem hiding this comment.
💡 Optional Recommendation
Issue: The changelog entry could be more descriptive about the bug fix implementation.
Fix: Add more context about how the bug was fixed to help developers understand the change better.
Impact: Improves documentation and helps developers understand what changed in this version.
Suggested change
| v.3.12.1 | |
| - Fixed bug - SDK crashes when Meta AEM query param `al_applink_data` is empty. | |
| v.3.12.1 | |
| - Fixed bug - SDK crashes when Meta AEM query param `al_applink_data` is empty. Added null check to safely handle empty parameter values. | |
gdeluna-branch
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference
Release 3.12.1 Updates
Summary
Motivation
Type Of Change
Testing Instructions
cc @BranchMetrics/saas-sdk-devs for visibility.