EMT- Removed apple_receipt and apple_testflight param from the Server Requests #1520
Conversation
|
Summary By MatterAI
🔄 What ChangedThis Pull Request's title and body state the removal of 🔍 Impact of the ChangeThe workflow modifications simplify the CI/CD configuration, potentially leading to slightly faster and more robust build processes by relying on the default Xcode version provided by the runner. If the stated parameter removal also occurred (though not shown in the patch), it would reduce request payload size, potentially mitigating HTTP 413 errors and improving API efficiency. 🚀 📁 Total Files Changed
🧪 Test AddedNo new functional tests are visible in the provided patch. The changes are to CI/CD configuration. 🧪 🔒Security VulnerabilitiesNo new security vulnerabilities are introduced by the workflow changes. The stated removal of unused parameters from server requests could be considered a minor security improvement by reducing the attack surface. 🛡️ Tip Quality Recommendations
Tanka Poem ♫
Sequence DiagramsequenceDiagram
participant Client as Mobile App
participant Server as Backend Service
Client->>Server: initSession(param1, param2)
Note over Server: Previously included apple_receipt and apple_testflight
Note over Server: Now these parameters are removed from the request payload
Server->>Server: ProcessSessionRequest(param1, param2)
Server-->>Client: SessionResponse
|
|
/matter summary |
|
/matter review |
Summary By MatterAI
🔄 What ChangedThis Pull Request primarily focuses on removing the 🔍 Impact of the ChangeThis change streamlines the Branch SDK by eliminating the collection and transmission of Apple receipt information, which can lead to improved privacy compliance and reduced payload sizes for server requests. The removal of unused code enhances the SDK's maintainability and reduces its footprint. The CI/CD updates ensure a standardized and consistent build environment across various integration verification jobs, thereby improving the reliability and predictability of the build process. 🛠️ 📁 Total Files Changed
🧪 Test AddedNo new tests were added. The existing test file 🔒Security VulnerabilitiesNo new security vulnerabilities were introduced. The removal of data collection for Apple receipt information can be seen as a positive step towards enhancing user privacy. ✅ |
![matter-code-review[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
There was a problem hiding this comment.
Clean removal of Apple Receipt functionality with proper CI/CD improvements. Added Xcode version pinning across workflows and fixed missing artifact path.
Skipped files
Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj: Skipped file patternBranchSDK.xcodeproj/project.pbxproj: Skipped file pattern
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
2 participants
Reference
EMT-2305 - 413 HTTP error on initSession
https://branch.atlassian.net/browse/EMT-2305
#1511
Summary
Removed Apple Receipt param from Server Requests. Its not used by backend and related Apple API is deprecated now.
Type Of Change
cc @BranchMetrics/saas-sdk-devs for visibility.