Skip to content

Retry logic updated for Http Response Codes 1xx, 2xx, 3xx and 4xx. #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

Retry logic updated for Http Response Codes 1xx, 2xx, 3xx and 4xx. #1525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbcfefb
V2 events will be removed from request queue on 4xx response error co…
NidhiDixit09 Sep 8, 2025
a9595e5
Updated retry status.
NidhiDixit09 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Sources/BranchSDK/Branch.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1899,19 +1899,18 @@ static inline void BNCPerformBlockOnMainThreadSync(dispatch_block_t block) {
}
}

//static inline void BNCPerformBlockOnMainThreadAsync(dispatch_block_t block) {
// dispatch_async(dispatch_get_main_queue(), block);
//}

- (void) processRequest:(BNCServerRequest*)req
response:(BNCServerResponse*)response
error:(NSError*)error {

// If the request was successful, or was a bad user request, continue processing.
// Also skipping retry for 1xx(Informational), 2xx(Success), 3xx(Redirectional Message) and 4xx(Client)error codes.
if (!error ||
error.code == BNCTrackingDisabledError ||
error.code == BNCBadRequestError ||
error.code == BNCDuplicateResourceError) {
error.code == BNCDuplicateResourceError ||
((100 <= error.code) && (error.code <= 499))) {

BNCPerformBlockOnMainThreadSync(^{
[req processResponse:response error:error];
Expand Down