Disabled Deprecation warning for StoreKit(Original) APIs

[NidhiDixit09]

Reference

EMT-2434 - StoreKit APIs Deprecation
https://branch.atlassian.net/browse/EMT-2434

Summary

Motivation

Type Of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Testing Instructions

cc @BranchMetrics/saas-sdk-devs for visibility.

[matter-code-review]

Summary By MatterAI

🔄 What Changed

This Pull Request introduces compiler directives to disable deprecation warnings specifically for StoreKit (Original) APIs within the BranchEvent interface. The #pragma clang diagnostic push, #pragma clang diagnostic ignored "-Wdeprecated-declarations", and #pragma clang diagnostic pop directives have been added around the BranchEvent class definition in BranchEvent.h.

🔍 Impact of the Change

The primary impact is the suppression of compiler warnings related to the use of deprecated StoreKit APIs. This change aims to clean up build logs by preventing these warnings from appearing, potentially allowing the project to compile without warning noise. However, it also means that actual deprecation issues for these specific APIs will no longer be highlighted by the compiler, which could mask underlying technical debt or future compatibility problems if not managed proactively.

📁 Total Files Changed

• Sources/BranchSDK/Public/BranchEvent.h: Added 5 lines to suppress deprecation warnings.

🧪 Test Added

No specific tests were added as part of this change.

🔒Security Vulnerabilities

No direct security vulnerabilities were introduced or fixed by this change. However, suppressing warnings can sometimes hide potential issues if the deprecated APIs have security implications that are no longer being actively maintained or updated.

Tip

Quality Recommendations

1. Investigate the deprecated StoreKit APIs and formulate a plan for migration to modern alternatives to avoid future compatibility issues and technical debt.

2. Add a concise comment explaining the reason for suppressing the deprecation warnings and, if possible, a timeline or reference to the migration plan.

Tanka Poem ♫

Warnings silenced now,
Old code breathes, a quiet hum.
Future's call awaits,
Migration, a task for minds,
Evolution's steady march. 🔬✨

Sequence Diagram

sequenceDiagram
    participant Compiler
    participant BranchEvent_h as BranchEvent.h
    
    Compiler->>BranchEvent_h: Parse file content
    BranchEvent_h-->>Compiler: Encounter #pragma clang diagnostic push
    BranchEvent_h-->>Compiler: Encounter #pragma clang diagnostic ignored "-Wdeprecated-declarations"
    Note over Compiler: Suppress deprecation warnings for StoreKit APIs
    Compiler->>BranchEvent_h: Process @interface BranchEvent
    BranchEvent_h-->>Compiler: Encounter #pragma clang diagnostic pop
    Note over Compiler: Resume default warning behavior

Loading

[matter-code-review]

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use MatterAI

Command List

• /matter summary: Generate AI Summary for the PR
• /matter review: Generate AI Reviews for the latest commit in the PR
• /matter review-full: Generate AI Reviews for the complete PR
• /matter release-notes: Generate AI release-notes for the PR
• /matter : Chat with your PR with MatterAI Agent
• /matter remember : Generate AI memories for the PR
• /matter explain: Get an explanation of the PR
• /matter help: Show the list of available commands and documentation
• Need help? Join our Discord server: https://discord.gg/fJU5DvanU3