Skip to content

Conversation

NidhiDixit09
Copy link
Collaborator

Reference

SDK-XXXX -- <TITLE>.

Summary

Motivation

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link
Contributor

matter-code-review bot commented Sep 24, 2025

Code Quality bug fix maintainability

Summary By MatterAI MatterAI logo

🔄 What Changed

This Pull Request combines two distinct updates: 1️⃣ The Branch SDK version was updated from 3.13.1 to 3.13.2 across its CocoaPods specification, internal Objective-C configuration, and versioning script. 2️⃣ The callbackForTracingRequests typedef in Sources/BranchSDK/Public/BNCCallbacks.h was modified to explicitly mark the requestServiceURL parameter as _Nullable, enhancing type safety and Swift interoperability.

🔍 Impact of the Change

These changes ensure consistent SDK versioning for accurate dependency management and build processes. The nullability annotation improves the robustness of the SDK's API contract, preventing potential nil-related issues when consumed by Swift code and providing clearer compile-time checks for developers.

📁 Total Files Changed

  • BranchSDK.podspec: Updated s.version to 3.13.2.
  • Sources/BranchSDK/BNCConfig.m: Updated BNC_SDK_VERSION to 3.13.2.
  • scripts/version.sh: Updated version variable to 3.13.2.
  • Sources/BranchSDK/Public/BNCCallbacks.h: Added _Nullable annotation to requestServiceURL parameter in callbackForTracingRequests typedef.

🧪 Test Added

No explicit tests were added in this Pull Request. The changes are primarily version string updates and a type definition enhancement, which typically do not require new unit tests for the changes themselves.

🔒Security Vulnerabilities

No security vulnerabilities were detected or introduced by these changes. The updates are declarative and enhance type safety without altering functional or security-sensitive logic.

Tanka Poem ♫

Nullability's grace,
Code now safer, Swift can trust,
No more nil's dark dread.
Version bumps, a steady beat,
SDK grows, strong and clear.

Sequence Diagram

sequenceDiagram
    participant SDKInternal as Branch SDK Internal
    participant NetworkService as External Network Service
    participant TracingConsumer as App/Tracing Logic
    
    Note over SDKInternal: SDK initiates an operation
    SDKInternal->>NetworkService: Perform API Request (url, headers, body)
    NetworkService-->>SDKInternal: API Response (status, data, error)
    
    Note over SDKInternal: Prepare tracing data, including potentially nullable requestServiceURL
    SDKInternal->>TracingConsumer: callbackForTracingRequests(url, request, response, error, requestServiceURL)
    Note over TracingConsumer: Process tracing information, handling nullable requestServiceURL
Loading

Copy link
Contributor

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use MatterAI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with MatterAI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

Copy link
Contributor

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use MatterAI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with MatterAI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

@NidhiDixit09 NidhiDixit09 merged commit c17349a into master Sep 24, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants