Fixed bug for sending appleAttributionToken in the server requests.

[NidhiDixit09]

Reference

SDK-XXXX -- <TITLE>.

Summary

Motivation

Type Of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Testing Instructions

-> Install an app on Real Device with Branch SDK integrated.
-> Branch Server Install request should contain following param :
"apple_attribution_token" : "\/G1Xzv\/41vssesrxfQUe ............ 8hhwAAAAAAAAABBEsIAAA=",
-> If its not sent with install, it should go with next open.
-> Once its sent, following OPEN requests should not include it.

cc @BranchMetrics/saas-sdk-devs for visibility.

[matter-code-review]

Summary By MatterAI

🔄 What Changed

This Pull Request addresses a bug related to the handling of the appleAttributionToken. Specifically, it removes a conditional block within the loadDataFromThirdPartyAPIs method in BNCRequestFactory.m. Previously, if self.appleAttributionToken was present, the preferenceHelper.appleAttributionTokenChecked flag was set to YES. This conditional logic has now been removed.

🔍 Impact of the Change

By removing the conditional setting of appleAttributionTokenChecked, the system's behavior regarding the appleAttributionToken is altered. The PR title indicates this change is a bug fix, suggesting the previous logic was incorrectly preventing the token from being sent or processed as intended. The removal likely ensures the appleAttributionToken is handled correctly in subsequent server requests, resolving the identified issue.

📁 Total Files Changed

• Sources/BranchSDK/BNCRequestFactory.m: Removed 3 lines of code related to setting the appleAttributionTokenChecked flag.

🧪 Test Added

No new tests were added or modified in this Pull Request.

🔒Security Vulnerabilities

No new security vulnerabilities were introduced or fixed by this change. The modification is focused on correcting the logic for an existing attribution token.

Tanka Poem ♫

Token's path now clear,
Old check, a bug, now gone.
Data flows with ease,
Attribution finds its mark,
Truth in every byte now sent. 🍎

Sequence Diagram

sequenceDiagram
    participant RF as BNCRequestFactory
    participant SO as BNCSystemObserver
    participant PH as BNCPreferenceHelper
    
    Note over RF: In loadDataFromThirdPartyAPIs (async block)
    RF->>SO: appleAttributionToken()
    SO-->>RF: appleAttributionToken
    
    Note over RF: Previously, RF would conditionally update PH.
    Note over RF: This conditional update has been removed.
    
    opt Removed Logic
        RF->>PH: setAppleAttributionTokenChecked(YES)
    end

Loading

[matter-code-review]

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use MatterAI

Command List

• /matter summary: Generate AI Summary for the PR
• /matter review: Generate AI Reviews for the latest commit in the PR
• /matter review-full: Generate AI Reviews for the complete PR
• /matter release-notes: Generate AI release-notes for the PR
• /matter : Chat with your PR with MatterAI Agent
• /matter remember : Generate AI memories for the PR
• /matter explain: Get an explanation of the PR
• /matter help: Show the list of available commands and documentation
• Need help? Join our Discord server: https://discord.gg/fJU5DvanU3