Perf() : replace jscs with eslint#933
Open
JagadeeshKaricherla-branch wants to merge 6 commits intomainfrom
Open
Perf() : replace jscs with eslint#933JagadeeshKaricherla-branch wants to merge 6 commits intomainfrom
JagadeeshKaricherla-branch wants to merge 6 commits intomainfrom
Conversation
replace jscs with eslint
fix eof issue
fix eof issue
Contributor
update package lock
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
=========================================
Coverage ? 24.60%
=========================================
Files ? 15
Lines ? 2321
Branches ? 0
=========================================
Hits ? 571
Misses ? 1750
Partials ? 0 |
fix linting issues reated to double quotes
| @@ -0,0 +1,2 @@ | |||
| node_modules/ | |||
| dist/ | |||
There was a problem hiding this comment.
Should newline eof char be added?
|
Most of these changes are just from executing the eslint tool right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Replace linting tool from jscs ( package deprecated ) to eslint
Fixes # (issue)
Type of change : performance
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
JS Budget Check
Please mention the size in kb before abd after this PR
Checklist:
Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.