Skip to content

add onlyMember modifier to decommission #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exo404 merged 1 commit into from
Mar 17, 2026
Merged

add onlyMember modifier to decommission #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/contracts/SavingCircles.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ contract SavingCircles is ISavingCircles, ReentrancyGuardUpgradeable, OwnableUpg
}

/// @inheritdoc ISavingCircles
function decommission(uint256 _id) external override nonReentrant onlyActive(_id) {
function decommission(uint256 _id) external override nonReentrant onlyActive(_id) onlyMember(_id, msg.sender) {
if (!_isDecommissionable(_id)) revert NotDecommissionable();

address token = circles[_id].token;
Expand Down
4 changes: 3 additions & 1 deletion test/unit/SavingCirclesUnit.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,9 +644,11 @@ contract SavingCirclesUnit is SavingCirclesTestBase {
function test_DecommissionWhenOwner() external {
vm.warp(block.timestamp + DEPOSIT_INTERVAL + 1);

vm.startPrank(alice);
vm.expectEmit(true, true, true, true);
emit ISavingCircles.CircleDecommissioned(baseCircleId);
savingCircles.decommission(baseCircleId);
vm.stopPrank();

vm.expectRevert(abi.encodeWithSelector(ISavingCircles.NotCommissioned.selector));
savingCircles.getCircle(baseCircleId);
Expand Down Expand Up @@ -1086,7 +1088,7 @@ contract SavingCirclesUnit is SavingCirclesTestBase {
function test_DecommissionWhenNotOwnerOrMember() external {
// Test that non-owner/non-member cannot decommission
vm.prank(STRANGER);
vm.expectRevert(ISavingCircles.NotDecommissionable.selector);
vm.expectRevert(ISavingCircles.NotMember.selector);
savingCircles.decommission(baseCircleId);
}

Expand Down
Loading