sp_BlitzIndex: Added warning for persisted sample rates. #3680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3679 .
This was disturbingly easy. You will want to check over it very carefully. The only place where I really had to think was the dynamic SQL. I don't have super old versions of SQL Server hanging around, so I have not been able to test any branches other than the one that my 2022 Docker container hits.
The URL that I have given is the best that I could find. I cannot think of anyone who has spoken with the voice of experience about
PERSIST_SAMPLE_PERCENT.I might make an issue for us also not having incremental statistics, but the merge conflict will be a pain unless this is merged first.